Re: [PATCH 2/2] IPVS: Add genetlink interface implementation

To: "Patrick McHardy" <kaber@xxxxxxxxx>
Subject: Re: [PATCH 2/2] IPVS: Add genetlink interface implementation
Cc: netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, vbusam@xxxxxxxxxx, horms@xxxxxxxxxxxx, davem@xxxxxxxxxxxxx
From: "Julius Volz" <juliusv@xxxxxxxxxx>
Date: Thu, 10 Jul 2008 15:58:34 +0200
On Thu, Jul 10, 2008 at 2:15 PM, Patrick McHardy <kaber@xxxxxxxxx> wrote:
> There probably should be a struct module *owner in the
> ops registered with genetlink. This is necessary at
> least to make sure that modules don't disappear during
> dumps.

There seems to be no such thing in genetlink. af_netlink.c tracks the
owner of a netlink socket, but that would increase the use count of
the genetlink module.

First I would have suspected the genl_mutex to be held while dumping,
so that at least unregistering the family at module unload would
block. But the mutex is explicitly unlocked for the duration of the
netlink dump:


                err = netlink_dump_start(genl_sock, skb, nlh,
                                         ops->dumpit, ops->done);


Google Switzerland GmbH
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>