|
Hello,
On Sat, 6 Nov 2010, Simon Horman wrote:
I wonder if we could just remove the modular aspect of persistence engines
as there is currently only one module and no plans on the drawing board
for any more at this time. That is, compile ip_vs_pe_sip directly
into ip_vs.ko
May be it is better svc to hold module refcnt for
PE as currently implemented. If in backup the svc and dest
are not found when creating connection with PE data then just
ignore the connection. The PE name must match the PE attached
to svc (ip_vs_find_dest). This check must exist. The benefit
comes from the fact that svc is freed after all its connections
are freed, cp->dest->svc is always valid. Then there is no
need for cp->pe. ip_vs_conn_hashkey_conn() has checks for
cp->dest, so there is no point to try to create synced
connections in backup with PE but without cp->dest.
The benefits:
- no cp->pe, it is not needed, the persistent scheduler
gets PE from svc, i.e. PEs are needed only during
scheduling, so svc, PE and dest are present
- PEs can be modular
Regards
--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
