LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [RFC v2] ipvs: allow transmit of GRO aggregated skbs

To: Simon Horman <simon@xxxxxxxxx>
Subject: Re: [RFC v2] ipvs: allow transmit of GRO aggregated skbs
Cc: Julian Anastasov <ja@xxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 8 Nov 2010 22:19:55 +0800
On Mon, Nov 08, 2010 at 08:45:42PM +0900, Simon Horman wrote:
>
> >     Yes, I think we should check for !skb_is_gso(skb)
> > as it looks as correct check to avoid FRAG_NEEDED after GRO
> > but lets wait for confirmation from Herbert Xu.
> 
> Yes, lets try and get a word from Herbert Xu on this.

Yes skb_is_gso(skb) is the best for now.  It isn't 100% correct
as we should still be checking that the gso_size is less than
the MTU but we need to fix that elsewhere first.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>