|
Hello,
On Tue, 1 Nov 2005, Roberto Nibali wrote:
> You've recently introduced the IP_VS_CONN_F_TEMPLATE flag in 2.4.x and
> 2.6.x, however in the ip_vs_bind_dest() function we have a significant
> difference between 2.6.x and 2.4.x. Why is the dest->inactconns counter
> in 2.4.x kernel not incremented for non template connections in
> ip_vs_bind_dest()?
May be because this code is older, Wensong moved the increment
into ip_vs_bind_dest for the 2.6 version and introduced dest->persistconns.
Before that change (referring to 2.4), every ip_vs_conn_new caller
incremented this counter except for templates, which is ugly.
> Please compare
>
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;h=f828fa2eb7dea154ff534e342fc75cdf8217b1ba;hb=87375ab47cd0ba04124c6d3fd80db5c368f5dcb6;f=net/ipv4/ipvs/ip_vs_conn.c#l381
>
> with:
>
> http://www.kernel.org/git/?p=linux/kernel/git/marcelo/linux-2.4.git;a=blob;h=015c8195dec1f11c5b31e15edb083c810464d2e4;hb=2afb6d8ea04e81a1547e8e51b7550a8fd69b9fce;f=net/ipv4/ipvs/ip_vs_conn.c#l1115
>
> I can hardly imagine this being a bug since a lot more people using
> 2.4.x would barf. I am just not so fluent anymore with the IPVS code,
> that's why I ask you directly.
The dest->inactconns usage in 2.4 should be correct, it does not
account templates as the value is used in schedulers.
Regards
--
Julian Anastasov <ja@xxxxxx>
|
