|
Hello,
On Tue, 1 Nov 2005, Roberto Nibali wrote:
> This little cleanup patch can be sent to Marcelo for 2.4.32 cleanup. It
> replaces the atomic_dec with the existing inlined refcnt decrement
> function in ip_vs.h and removes the comment since this comment can be
> found in ip_vs.h:
Yes, this is a cleanup and the change is valid but if you
really want it included in 2.4 you have to persuade Marcelo, after
rediffing the patch properly. OTOH, 2.4 and 2.6 are full with refcnt
usage, so better to leave them in this way, it is more readable
compared to any eventual _hold and _put alternatives.
> --- ../linux-2.4.32-orig/net/ipv4/ipvs/ip_vs_conn.c 2005-10-27
> 17:20:58 +020
> +++ net/ipv4/ipvs/ip_vs_conn.c 2005-11-01 11:04:31 +0100
> @@ -1187,12 +1220,7 @@
> ip_vs_conn_hash(ct);
> }
> }
> -
> - /*
> - * Simply decrease the refcnt of the template,
> - * don't restart its timer.
> - */
> - atomic_dec(&ct->refcnt);
> + __ip_vs_conn_put(ct);
> return 0;
> }
> return 1;
>
> Please consider applying,
> Roberto Nibali, ratz
Regards
--
Julian Anastasov <ja@xxxxxx>
|
