LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 2.4] use proper inlined function to decrement connection ref

To: "LinuxVirtualServer.org users mailing list." <lvs-users@xxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2.4] use proper inlined function to decrement connection refcnt
From: Roberto Nibali <ratz@xxxxxx>
Date: Wed, 02 Nov 2005 08:59:01 +0100
Hi Julian,

>       Yes, this is a cleanup and the change is valid but if you
> really want it included in 2.4 you have to persuade Marcelo, after
> rediffing the patch properly. OTOH, 2.4 and 2.6 are full with refcnt
> usage, so better to leave them in this way, it is more readable
> compared to any eventual _hold and _put alternatives.

Well, so the remaining _put's should be converted to atomic_dec()'s
then, to maintain code consistency.

Cheers,
Roberto Nibali, ratz
-- 
-------------------------------------------------------------
addr://Kasinostrasse 30, CH-5001 Aarau tel://++41 62 823 9355
http://www.terreactive.com             fax://++41 62 823 9356
-------------------------------------------------------------
terreActive AG                       Wir sichern Ihren Erfolg
-------------------------------------------------------------

<Prev in Thread] Current Thread [Next in Thread>