Re: [PATCH 2.4] use proper inlined function to decrement connection refcnt

[Horms <horms@xxxxxxxxxxxx>]

On Wed, Nov 02, 2005 at 08:59:01AM +0100, Roberto Nibali wrote:
> Hi Julian,
> 
> >     Yes, this is a cleanup and the change is valid but if you
> > really want it included in 2.4 you have to persuade Marcelo, after
> > rediffing the patch properly. OTOH, 2.4 and 2.6 are full with refcnt
> > usage, so better to leave them in this way, it is more readable
> > compared to any eventual _hold and _put alternatives.
> 
> Well, so the remaining _put's should be converted to atomic_dec()'s
> then, to maintain code consistency.

I don't have a particular problem with the patch you submitted,
though I share Julian's caution.

-- 
Horms