|
On 8/1/05, Peter Mueller <pmueller@xxxxxxxxxxxx> wrote:
> Hello Horms,
>
> Please consider adding this to CVS. It is diffed against CVS obtained from
> today. The functionality added is to send an email when a server goes in and
> out of service. You must change the two email address variables to make it
> work. Currently they are:
> +$ALERTEMAILOUTSERVICE = "outofservicemeailaddresshere@localhost";
> +$ALERTEMAILRESTORESERVICE = "restoreservicemeailaddresshere@localhost";
>
> http://world.anarchy.com/~peter/lvs/ldirectord.cvs.patch
>
> Depending on the server the 'restore' service is less useful because a
> ldirectord reload, such as kill -HUP ldirectord, will send out a restore for
> each server. Also, I am not certain what a solution would be for a user that
> does not want email. Comment out the two ld_alert instance calls by default?
> Or maybe change the default email to root@localhost?
Nice patch, but you're not even checking to see if /usr/lib/sendmail
exists or if it even ran without errors. Ideally you would make all
these variables, configuration variables as well. I'd have to say
this patch is incomplete, but it's a good idea.
-reid
|
